pvary opened a new pull request #2111:
URL: https://github.com/apache/iceberg/pull/2111


   After this change 
(_[HIVE-20129](https://issues.apache.org/jira/browse/HIVE-20129) Revert to 
position based schema evolution for orc tables_) in Hive the Iceberg ORC column 
projection is not working as expected.
   
   The effect:
   - If the table has 3 columns (customer_id, first_name, last_name)
   - And the query requests the last 2 columns (first_name, last_name)
   - We will read the first 2 (customer_id, first_name) instead of the 
requested ones
   
   I think it would be good to turn off this config for our Iceberg ORC readers 
as we expect it to be false anyway and other systems using Iceberg might need 
it to be set differently.
   
   The patch contains 3 groups of changes:
   - Test infra changes so we can change HMS configuration (this is used for 
HiveCatalog FileIO creation)
   - Actually setting the `orc.force.positional.evolution` to `true` in the 
tests - this causes 
`TestHiveIcebergStorageHandlerLocalScan.testColumnSelection()` to fail
   - Setting `orc.force.positional.evolution` to `false` in `ORC.ReadBuilder` 
to override the configuration values to the expected one - tis fixes the test 
failures


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to