pvary commented on a change in pull request #2111:
URL: https://github.com/apache/iceberg/pull/2111#discussion_r559759963
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -106,7 +115,9 @@ public void start(int poolSize) {
TServerSocket socket = new TServerSocket(0);
int port = socket.getServerSocket().getLocalPort();
- this.hiveConf = newHiveConf(port);
+ initConf(conf, port);
Review comment:
Before the change the configuration was created in `newHiveConf()`. The
new method changes values in the conf parameter. The change meant to emphasize
that we are not creating a new conf, only changing values in the one got in the
parameter list.
Shall we move back to create a new config and initialize that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
