rdblue commented on a change in pull request #2111:
URL: https://github.com/apache/iceberg/pull/2111#discussion_r559749363
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreTest.java
##########
@@ -38,7 +38,7 @@
@BeforeClass
public static void startMetastore() throws Exception {
HiveMetastoreTest.metastore = new TestHiveMetastore();
- metastore.start();
+ metastore.start(new HiveConf(HiveMetastoreTest.class));
Review comment:
Is this change needed? `start()` is still defined and uses
`HiveMetastoreTest.class`. The only difference is that this doesn't pass a
`Configuration` and the parameterless `start` passes `new Configuration()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
