rdblue commented on a change in pull request #2111:
URL: https://github.com/apache/iceberg/pull/2111#discussion_r559762201
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -106,7 +115,9 @@ public void start(int poolSize) {
TServerSocket socket = new TServerSocket(0);
int port = socket.getServerSocket().getLocalPort();
- this.hiveConf = newHiveConf(port);
+ initConf(conf, port);
Review comment:
I thought it was a necessary change to pass in the conf for some reason.
I'm okay either way. I just wanted to point out a way to make fewer changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
