rdblue commented on a change in pull request #2111:
URL: https://github.com/apache/iceberg/pull/2111#discussion_r559748609
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerTestUtils.java
##########
@@ -61,6 +62,7 @@ static TestHiveShell shell() {
TestHiveShell shell = new TestHiveShell();
shell.setHiveConfValue("hive.notification.event.poll.interval", "-1");
shell.setHiveConfValue("hive.tez.exec.print.summary", "true");
+
shell.setHiveConfValue(OrcConf.FORCE_POSITIONAL_EVOLUTION.getHiveConfName(),
"true");
Review comment:
Can you add a comment for this that explains why it is set for the Hive
tests? I think it could be confusing later that this is explicitly set to true,
only to be overridden by ORC when creating a reader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
