RussellSpitzer commented on code in PR #18540:
URL: https://github.com/apache/iceberg/pull/18540#discussion_r4405781030
##########
core/src/test/java/org/apache/iceberg/util/TestTasks.java:
##########
@@ -197,4 +222,143 @@ void
parallelTasksAreNotRetriedWhenTheCallerIsInterrupted() throws InterruptedEx
callerPool.shutdownNow();
}
}
+
+ @Test
Review Comment:
What does `parallelRunReturnsWhenTasksFinish` add on top of the
`RecordingExecutor` tests? Those should already fail against the polling
version, since they depend on `get()` being called on a future that isn't done
yet. I'm worried this one is the kind of test that fails on a noisy CI runner
rather than because of a real regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
