RussellSpitzer commented on code in PR #18540:
URL: https://github.com/apache/iceberg/pull/18540#discussion_r4405869665


##########
core/src/test/java/org/apache/iceberg/util/TestTasks.java:
##########
@@ -197,4 +222,143 @@ void 
parallelTasksAreNotRetriedWhenTheCallerIsInterrupted() throws InterruptedEx
       callerPool.shutdownNow();
     }
   }
+
+  @Test
+  public void parallelRunReturnsWhenTasksFinish() {

Review Comment:
   we should stay package private for tests now, I think we have a mix in this 
file but for new tests let's just keep them package-private (same for before 
and after)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to