raunaqmorarka commented on code in PR #18540:
URL: https://github.com/apache/iceberg/pull/18540#discussion_r4405936439
##########
core/src/test/java/org/apache/iceberg/util/TestTasks.java:
##########
@@ -197,4 +222,143 @@ void
parallelTasksAreNotRetriedWhenTheCallerIsInterrupted() throws InterruptedEx
callerPool.shutdownNow();
}
}
+
+ @Test
Review Comment:
Agreed, removed it.
The `RecordingExecutor` tests wait for `get()` on a running future. So they
already fail against the polling version.
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1720,7 +1722,7 @@ public void testRemoveSpecDuringExpiration() {
Set<String> deletedFiles = Sets.newHashSet();
// Expiring snapshots should remove the data_bucket partition
removeSnapshots(table)
- .expireOlderThan(System.currentTimeMillis())
+
.expireOlderThan(waitUntilAfter(table.currentSnapshot().timestampMillis()))
Review Comment:
Good point. Switched to `timestampMillis() + 1` at all five call sites.
##########
core/src/test/java/org/apache/iceberg/util/TestTasks.java:
##########
@@ -197,4 +222,143 @@ void
parallelTasksAreNotRetriedWhenTheCallerIsInterrupted() throws InterruptedEx
callerPool.shutdownNow();
}
}
+
+ @Test
+ public void parallelRunReturnsWhenTasksFinish() {
Review Comment:
Done. The new tests and `before`/`after` are package-private now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
