raunaqmorarka commented on PR #18540: URL: https://github.com/apache/iceberg/pull/18540#issuecomment-6480021015
> If we switched to a single pass with get couldn't we rid of all the "isDone" checks and move all the error handling to one place? Good point, waitFor is now a single pass. An Error is still thrown only after every task finishes. The loop keeps the first one and throws it at the end. Interrupts go through one catch now. It cancels the futures and restores the interrupt status, as before. The Error test now also checks that the other task finished first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
