RussellSpitzer commented on code in PR #18540:
URL: https://github.com/apache/iceberg/pull/18540#discussion_r4405839771
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1720,7 +1722,7 @@ public void testRemoveSpecDuringExpiration() {
Set<String> deletedFiles = Sets.newHashSet();
// Expiring snapshots should remove the data_bucket partition
removeSnapshots(table)
- .expireOlderThan(System.currentTimeMillis())
+
.expireOlderThan(waitUntilAfter(table.currentSnapshot().timestampMillis()))
Review Comment:
Not sure why we have to wait here, can't we just pass through
`table.currentSnapshot().timestampMillis() + 1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
