rdblue commented on a change in pull request #2096:
URL: https://github.com/apache/iceberg/pull/2096#discussion_r575716935
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -451,10 +470,24 @@ public TableMetadata withUUID() {
return this;
} else {
return new TableMetadata(null, formatVersion,
UUID.randomUUID().toString(), location,
- lastSequenceNumber, lastUpdatedMillis, lastColumnId, schema,
defaultSpecId, specs, lastAssignedPartitionId,
- defaultSortOrderId, sortOrders, properties, currentSnapshotId,
snapshots, snapshotLog,
- addPreviousFile(file, lastUpdatedMillis));
+ lastSequenceNumber, lastUpdatedMillis, lastColumnId,
currentSchemaId, schemas, defaultSpecId, specs,
+ lastAssignedPartitionId, defaultSortOrderId, sortOrders, properties,
+ currentSnapshotId, snapshots, snapshotLog, addPreviousFile(file,
lastUpdatedMillis));
+ }
+ }
+
+ private int reuseOrCreateNewSchemaId(Schema newSchema) {
Review comment:
Can you move this down to the bottom with other private helper methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
