rdblue commented on a change in pull request #2096:
URL: https://github.com/apache/iceberg/pull/2096#discussion_r575717275
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -661,9 +713,9 @@ public TableMetadata removeSnapshotLogEntries(Set<Long>
snapshotIds) {
"Cannot set invalid snapshot log: latest entry is not the current
snapshot");
return new TableMetadata(null, formatVersion, uuid, location,
- lastSequenceNumber, System.currentTimeMillis(), lastColumnId, schema,
defaultSpecId, specs,
- lastAssignedPartitionId, defaultSortOrderId, sortOrders, properties,
currentSnapshotId,
- snapshots, newSnapshotLog, addPreviousFile(file, lastUpdatedMillis));
+ lastSequenceNumber, System.currentTimeMillis(), lastColumnId,
currentSchemaId, schemas, defaultSpecId, specs,
+ lastAssignedPartitionId, defaultSortOrderId, sortOrders, properties,
currentSnapshotId, snapshots,
+ newSnapshotLog, addPreviousFile(file, lastUpdatedMillis));
Review comment:
Did `snapshots` need to move?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
