rdblue commented on a change in pull request #2096:
URL: https://github.com/apache/iceberg/pull/2096#discussion_r575717192
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -499,13 +548,14 @@ public TableMetadata updatePartitionSpec(PartitionSpec
newPartitionSpec) {
}
return new TableMetadata(null, formatVersion, uuid, location,
- lastSequenceNumber, System.currentTimeMillis(), lastColumnId, schema,
newDefaultSpecId,
+ lastSequenceNumber, System.currentTimeMillis(), lastColumnId,
currentSchemaId, schemas, newDefaultSpecId,
builder.build(), Math.max(lastAssignedPartitionId,
newPartitionSpec.lastAssignedFieldId()),
- defaultSortOrderId, sortOrders, properties,
- currentSnapshotId, snapshots, snapshotLog, addPreviousFile(file,
lastUpdatedMillis));
+ defaultSortOrderId, sortOrders, properties, currentSnapshotId,
snapshots, snapshotLog,
+ addPreviousFile(file, lastUpdatedMillis));
Review comment:
It looks like this change wasn't needed and just moves 3 variables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
