rdblue commented on a change in pull request #2096:
URL: https://github.com/apache/iceberg/pull/2096#discussion_r575714561
##########
File path: api/src/main/java/org/apache/iceberg/Schema.java
##########
@@ -54,6 +58,7 @@
private transient Map<Integer, String> idToName = null;
public Schema(List<NestedField> columns, Map<String, Integer> aliases) {
+ this.schemaId = 0;
Review comment:
I think we should add a constant for the default schema ID. That way we
can reference it in other places when we fill in the default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
