rdblue commented on a change in pull request #2096:
URL: https://github.com/apache/iceberg/pull/2096#discussion_r575715362
##########
File path: core/src/main/java/org/apache/iceberg/SchemaParser.java
##########
@@ -134,6 +143,10 @@ static void toJson(Type type, JsonGenerator generator)
throws IOException {
}
}
+ public static void toJsonWithId(Schema schema, JsonGenerator generator)
throws IOException {
Review comment:
This is only called in `TableMetadataParser` and I don't see why there
should be two `toJson` methods. It isn't a problem for the v1 metadata to be
written with the schema ID because extra fields are ignored. So I think that
this method isn't needed and `toJson` should always pass the ID to the struct
writer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
