openinx commented on a change in pull request #2845:
URL: https://github.com/apache/iceberg/pull/2845#discussion_r675464207
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -68,13 +68,15 @@ public static LocationProvider locationsFor(String
location, Map<String, String>
}
}
+ private static String defaultDataLocation(String tableLocation, Map<String,
String> properties) {
+ return properties.getOrDefault(TableProperties.WRITE_NEW_DATA_LOCATION,
String.format("%s/data", tableLocation));
Review comment:
To be honestly, I did not get what's the real meaning for
`TableProperties.WRITE_NEW_DATA_LOCATION`. If it's the configured default
location, then why did it name as `WRITE_NEW_DATA_LOCATION` with its real name
as `write.folder-storage.path`.
Now in this patch, we are trying to fallback to the
`write.folder-storage.path` when people did not set the
`write.object-storage.path`. It even make this more confuse to understand :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
