jackye1995 commented on a change in pull request #2845:
URL: https://github.com/apache/iceberg/pull/2845#discussion_r687290562
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -68,13 +68,15 @@ public static LocationProvider locationsFor(String
location, Map<String, String>
}
}
+ private static String defaultDataLocation(String tableLocation, Map<String,
String> properties) {
+ return properties.getOrDefault(TableProperties.WRITE_NEW_DATA_LOCATION,
String.format("%s/data", tableLocation));
Review comment:
Correct. Table location default is defined by the catalog
implementation, which is likely `s3://bucket/warehouse/db/tablename`, or a
custom override during create table. So that path slash data will always be
there when writing data, and this PR tries to use that as the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
