kbendick commented on a change in pull request #2845:
URL: https://github.com/apache/iceberg/pull/2845#discussion_r687285432
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -68,13 +68,15 @@ public static LocationProvider locationsFor(String
location, Map<String, String>
}
}
+ private static String defaultDataLocation(String tableLocation, Map<String,
String> properties) {
+ return properties.getOrDefault(TableProperties.WRITE_NEW_DATA_LOCATION,
String.format("%s/data", tableLocation));
Review comment:
I agree on the fallback strategy, though I'd like to see a warehouse
like set up for the whole catalog.
E.g. if I don't set `path`, per table, I'd like for it to work as
s3://bucket/warehouse/path/<tableLocation and/or just table
name>/<objectstorage_hash>/data
Is that more or less what this config is achieving?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
