kbendick commented on a change in pull request #2845:
URL: https://github.com/apache/iceberg/pull/2845#discussion_r687295370
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -68,13 +68,15 @@ public static LocationProvider locationsFor(String
location, Map<String, String>
}
}
+ private static String defaultDataLocation(String tableLocation, Map<String,
String> properties) {
+ return properties.getOrDefault(TableProperties.WRITE_NEW_DATA_LOCATION,
String.format("%s/data", tableLocation));
Review comment:
My only concern is with some potential confusion around the existence of
`write.object-storage.*` and then falling back to `write.folder-storage.*`. I
admittedly have enough trouble as it is convincing people that object-storage
keys are not folders 🙂, but I don't think that's necessarily a large enough
concern to introduce new table properties.
Given that it's an existing property though, I do think it makes sense.
In this example, with object storage location provider, where would the hash
/ entropy characters be placed in the path?
Am I correct in assuming that the transformation would be as follows?
`s3://bucket/warehouse/db/tablename` ->
`s3://bucket/warehouse/db/tablename/<hash>/data`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
