jackye1995 commented on a change in pull request #2845:
URL: https://github.com/apache/iceberg/pull/2845#discussion_r687291449
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -68,13 +68,15 @@ public static LocationProvider locationsFor(String
location, Map<String, String>
}
}
+ private static String defaultDataLocation(String tableLocation, Map<String,
String> properties) {
+ return properties.getOrDefault(TableProperties.WRITE_NEW_DATA_LOCATION,
String.format("%s/data", tableLocation));
Review comment:
The main discussion point I think is if we should have
`write.folder-storage.path` as a part of the fallback, which I think is worth
having, but I do agree it increases the complexity for path resolution which is
already quite complicated in Iceberg. If no one else objects the current
approach, I will merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
