jackye1995 commented on pull request #2845: URL: https://github.com/apache/iceberg/pull/2845#issuecomment-897900861
@kbendick thanks for the approval. We discussed offline, and I think the use cases that we are trying to achieve require this fallback strategy. Use case 1: user creates table and want to use `ObjectStorageLocationProvider` with the default table path. Currently this will throw a NPE because it requires `write.object-storage.path` to be set. But the user might not really know what is the root path of the table, and we should not break this abstraction. So a fallback to the default table root path should be desirable. Use case 2: user has an existing table with `write.folder-storage.path` set, and would like to enable object storage mode by updating the table property. With change to use case 1, this will directly fallback to the default table location instead of the folder storage path, but the correct behavior is for the Iceberg table to respect the `write.folder-storage.path` and use it as the root. So the 2 levels of fallback is required. I will go merge the PR, thanks for all the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
