stevenzwu commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r709454946
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -135,8 +136,10 @@ protected long pos(T record) {
Iterable<CloseableIterable<Record>> deleteRecords =
Iterables.transform(deletes,
delete -> openDeletes(delete, deleteSchema));
StructLikeSet deleteSet = Deletes.toEqualitySet(
- // copy the delete records because they will be held in a set
- CloseableIterable.transform(CloseableIterable.concat(deleteRecords),
Record::copy),
+ CloseableIterable.transform(
+ CloseableIterable.concat(deleteRecords,
ThreadPools.getWorkerPool(), ThreadPools.getPoolParallelism()),
Review comment:
did this PR actually change or increase the parallelism? it seems to me
we are still using the default parallelism of `2 *
ThreadPools.WORKER_THREAD_POOL_SIZE`. Is the purpose of this PR mainly
refactoring the API and supporting different parallelism (if needed in the
future)?
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -205,14 +212,12 @@ protected boolean shouldKeep(T item) {
case AVRO:
return Avro.read(input)
.project(deleteSchema)
- .reuseContainers()
Review comment:
is this related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
