jackye1995 commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r709725668
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -189,7 +192,11 @@ protected boolean shouldKeep(T item) {
if (posDeletes.stream().mapToLong(DeleteFile::recordCount).sum() <
setFilterThreshold) {
return Deletes.filter(
records, this::pos,
- Deletes.toPositionSet(dataFile.path(),
CloseableIterable.concat(deletes)));
+ Deletes.toPositionSet(
+ dataFile.path(),
+ CloseableIterable.concat(deletes, ThreadPools.getWorkerPool(),
ThreadPools.getPoolParallelism())
Review comment:
+1, something like `read.delete.position.num-threads` table property can
work.
In general we follow this pattern when configuring and creating thread pools
and executor service:
https://github.com/apache/iceberg/blob/master/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java#L187-L194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
