Reo-LEI commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r709837979
##########
File path: api/src/main/java/org/apache/iceberg/io/ParallelIterable.java
##########
@@ -72,8 +73,7 @@ private ParallelIterator(Iterable<? extends Iterable<T>>
iterables,
}
}).iterator();
this.workerPool = workerPool;
- // submit 2 tasks per worker at a time
- this.taskFutures = new Future[2 * ThreadPools.WORKER_THREAD_POOL_SIZE];
+ this.taskFutures = new Future[parallelism];
Review comment:
I wanna to do this at first, but `ExecutorService` does not seem to
provide the API to get the pool size. I think the reason is only part of
`ExecutorService` will concern the pool size, and such as pool size of
`CachedThreadPool` will be `Integer.MAX_VALUE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
