Reo-LEI commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r709766801
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -135,8 +136,10 @@ protected long pos(T record) {
Iterable<CloseableIterable<Record>> deleteRecords =
Iterables.transform(deletes,
delete -> openDeletes(delete, deleteSchema));
StructLikeSet deleteSet = Deletes.toEqualitySet(
- // copy the delete records because they will be held in a set
- CloseableIterable.transform(CloseableIterable.concat(deleteRecords),
Record::copy),
+ CloseableIterable.transform(
+ CloseableIterable.concat(deleteRecords,
ThreadPools.getWorkerPool(), ThreadPools.getPoolParallelism()),
Review comment:
The purpose of this PR is to be able to read deleteFile in parallel,
before this PR, iceberg will read all delete files in one thread serially.
Now, delete files will be read in parallel by a worker pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
