rdblue commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r709651949
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -189,7 +192,11 @@ protected boolean shouldKeep(T item) {
if (posDeletes.stream().mapToLong(DeleteFile::recordCount).sum() <
setFilterThreshold) {
return Deletes.filter(
records, this::pos,
- Deletes.toPositionSet(dataFile.path(),
CloseableIterable.concat(deletes)));
+ Deletes.toPositionSet(
+ dataFile.path(),
+ CloseableIterable.concat(deletes, ThreadPools.getWorkerPool(),
ThreadPools.getPoolParallelism())
Review comment:
I think that parallelizing this requires adding an option. There are
many cases where we wouldn't want to parallelize and cases where we want to use
a thread pool besides the shared worker pool. It would be better to pass a pool
in and parallelize if it is non-null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
