rdblue commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r711823144
##########
File path: core/src/main/java/org/apache/iceberg/util/ThreadPools.java
##########
@@ -38,6 +38,9 @@ private ThreadPools() {
WORKER_THREAD_POOL_SIZE_PROP,
Runtime.getRuntime().availableProcessors());
+ // In default, we submit 2 tasks per worker at a time.
+ public static final int WORKER_THREAD_POOL_PARALLELISM =
WORKER_THREAD_POOL_SIZE * 2;
Review comment:
This doesn't make sense here and complicates the `ParallelIterator` API.
I think the parallel iterator should just double the parallelism and document
that it expects the parallelism to be the pool size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
