rdblue commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r717123130
##########
File path: api/src/main/java/org/apache/iceberg/io/ParallelIterable.java
##########
@@ -28,25 +28,25 @@
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Future;
import org.apache.iceberg.exceptions.RuntimeIOException;
-import org.apache.iceberg.io.CloseableGroup;
-import org.apache.iceberg.io.CloseableIterable;
-import org.apache.iceberg.io.CloseableIterator;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
-public class ParallelIterable<T> extends CloseableGroup implements
CloseableIterable<T> {
+class ParallelIterable<T> extends CloseableGroup implements
CloseableIterable<T> {
private final Iterable<? extends Iterable<T>> iterables;
private final ExecutorService workerPool;
+ private final int workerPoolSize;
- public ParallelIterable(Iterable<? extends Iterable<T>> iterables,
- ExecutorService workerPool) {
+ ParallelIterable(Iterable<? extends Iterable<T>> iterables,
+ ExecutorService workerPool,
+ int workerPoolSize) {
Review comment:
We can't just remove the `public` modifier. Can you add `@Deprecated`
annotations and a `@deprecated` javadoc comment to the class and constructor
that states that you should use `CloseableIterable.combine` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
