rdblue commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r717122703
##########
File path: api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
##########
@@ -117,6 +118,16 @@ public O next() {
};
}
+ static <E> CloseableIterable<E> combine(Iterable<CloseableIterable<E>>
iterable,
+ ExecutorService workerPool,
+ int workerPoolSize) {
+ if (workerPool == null) {
+ return concat(iterable);
+ }
+ Preconditions.checkArgument(workerPoolSize > 0, "Invalid workerPoolSize
(not positive): " + workerPoolSize);
Review comment:
Style: in this project, we use empty lines to separate control flow
blocks from the following statements.
I'd also add a new line after the precondition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
