rdblue commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r711823468
##########
File path: api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
##########
@@ -117,6 +118,14 @@ public O next() {
};
}
+ static <E> CloseableIterable<E> combine(Iterable<? extends Iterable<E>>
iterable,
+ ExecutorService executorService,
+ int parallelism) {
+ Preconditions.checkNotNull(executorService, "ExecutorService shouldn't be
null");
Review comment:
You may want to allow null if the parallelism is 1. That will make the
calling code much easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
