rdblue commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r717123685
##########
File path: api/src/main/java/org/apache/iceberg/io/ParallelIterable.java
##########
@@ -72,8 +73,8 @@ private ParallelIterator(Iterable<? extends Iterable<T>>
iterables,
}
}).iterator();
this.workerPool = workerPool;
- // submit 2 tasks per worker at a time
- this.taskFutures = new Future[2 * ThreadPools.WORKER_THREAD_POOL_SIZE];
+ // In default, we submit 2 tasks per worker at a time.
Review comment:
Style: please remove personal pronouns. Using "we" or "I" makes
documentation longer and less direct. Also, no need for punctuation in line
comments.
Actually, I don't think that this comment needs to change at all. It looks
perfectly fine without the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
