rdblue commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r744329517
##########
File path: core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java
##########
@@ -151,7 +151,7 @@ protected void validate(TableMetadata base) {
if (deletedDataFiles.size() > 0) {
validateNoNewDeletesForDataFiles(
base, startingSnapshotId, conflictDetectionFilter,
- deletedDataFiles, caseSensitive);
+ deletedDataFiles, caseSensitive, false);
Review comment:
It isn't clear what's happening here. If you're introducing a new method
argument, can you add an override so that this doesn't need to change? If you
think that the boolean is needed, then can you add an inline comment to explain
what you're setting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
