rdblue commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r744332383



##########
File path: core/src/main/java/org/apache/iceberg/ManifestWriter.java
##########
@@ -149,13 +150,17 @@ public long length() {
     return writer.length();
   }
 
+  void useSequenceNumber(long sequenceNumber) {

Review comment:
       I think the cleanest way to do this is to add a new `add` method:
   
   ```java
     /**
      * Add an added entry for a file at a specific sequence number.
      * <p>
      * The entry's snapshot ID will be this manifest's snapshot ID.
      *
      * @param addedFile a data file
      * @param sequenceNumber sequence number for the data file
      */
     public void add(F addedFile, long sequenceNumber) {
       addEntry(reused.wrapAppend(snapshotId, sequenceNumber, addedFile));
     }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to