Reo-LEI commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r744413275
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
##########
@@ -77,6 +77,17 @@
*/
String TARGET_FILE_SIZE_BYTES = "target-file-size-bytes";
+ /**
+ * If the compaction should commit rewritten data files using the sequence
number at compaction start time instead
+ * of optimistically incrementing the latest sequence number.
+ * <p>
+ * This avoids commit conflicts with updates that add newer equality deletes
at a higher sequence number.
+ * <p>
+ * Defaults to false.
+ */
+ String USE_STARTING_SEQUENCE_NUMBER = "use-starting-sequence-number";
+ boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = false;
Review comment:
+1. And I have some concerns. In what situation do users need to use the
new sequence number when commit the rewritten data file instead of using the
starting sequence number? Maybe this configuration is not necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
