rdblue commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r744331755
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -327,8 +331,14 @@ protected void
validateNoNewDeletesForDataFiles(TableMetadata base, Long startin
for (DataFile dataFile : dataFiles) {
// if any delete is found that applies to files written in or before the
starting snapshot, fail
- if (deletes.forDataFile(startingSequenceNumber, dataFile).length > 0) {
- throw new ValidationException("Cannot commit, found new delete for
replaced data file: %s", dataFile);
+ DeleteFile[] deleteFiles = deletes.forDataFile(startingSequenceNumber,
dataFile);
+ if (ignoreEqualityDeletes) {
+ ValidationException.check(Arrays.stream(deleteFiles)
+ .noneMatch(deleteFile -> deleteFile.content() ==
FileContent.POSITION_DELETES),
Review comment:
Can you wrap the line after `check`? I think it looks strange to have a
double indent because the first part of the line wasn't wrapped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
