rdblue commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r744332669
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -309,10 +312,11 @@ protected void
validateNoNewDeletesForDataFiles(TableMetadata base, Long startin
* @param dataFilter a data filter
* @param dataFiles data files to validate have no new row deletes
* @param caseSensitive whether expression binding should be case-sensitive
+ * @param ignoreEqualityDeletes whether equality deletes should be ignored
in validation
*/
protected void validateNoNewDeletesForDataFiles(TableMetadata base, Long
startingSnapshotId,
Expression dataFilter,
Iterable<DataFile> dataFiles,
- boolean caseSensitive) {
+ boolean caseSensitive,
boolean ignoreEqualityDeletes) {
Review comment:
I think this makes sense for the internal API, but I generally prefer
new method names for booleans, like `validateNoNewPositionDeletesForDataFiles`
and `validateNoNewDeletesForDataFiles`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
