jackye1995 commented on a change in pull request #4371:
URL: https://github.com/apache/iceberg/pull/4371#discussion_r831753081
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -208,6 +209,14 @@
*/
public static final String CLIENT_FACTORY = "client.factory";
+ /**
+ * The implementation class of {@link
software.amazon.awssdk.http.SdkHttpClient} used by {@link AwsClientFactory}
+ * If set, all AWS clients will use this specified HTTP client.
+ * If not set, CLIENT_HTTP_TYPE_DEFAULT will be used.
+ */
+ public static final String CLIENT_HTTP_TYPE = "client.http.type";
+ public static final String CLIENT_HTTP_TYPE_DEFAULT =
UrlConnectionHttpClient.class.getName();
Review comment:
also because we are talking about "type" but not "impl" here, prefer to
use shorter strings instead of full class name. In this case, 2 types could be
"url" and "apache"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
