jackye1995 commented on a change in pull request #4371:
URL: https://github.com/apache/iceberg/pull/4371#discussion_r831753917
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java
##########
@@ -97,12 +99,13 @@ public void initialize(Map<String, String> properties) {
clientBuilder.credentialsProvider(
StsAssumeRoleCredentialsProvider.builder()
-
.stsClient(StsClient.builder().httpClientBuilder(UrlConnectionHttpClient.builder()).build())
+ .stsClient(StsClient.builder().httpClientBuilder(
Review comment:
I think we should have a private method for `sts()` similar to what you
have for `lakeformation()`, it makes the code more clear about all the AWS
clients
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
