jackye1995 commented on a change in pull request #4371:
URL: https://github.com/apache/iceberg/pull/4371#discussion_r832431532
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java
##########
@@ -38,6 +40,8 @@
public class AwsClientFactories {
+ public static final String APACHE_HTTP_TYPE = "apache";
Review comment:
this should be in `AwsProperties`, with variables
`CLIENT_HTTP_TYPE_APACHE`, `CLIENT_HTTP_TYPE_URL`, `CLIENT_HTTP_TYPE_DEFAULT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
