jackye1995 commented on a change in pull request #4371:
URL: https://github.com/apache/iceberg/pull/4371#discussion_r831753451
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java
##########
@@ -118,6 +121,18 @@ public void initialize(Map<String, String> properties) {
ValidationException.check((s3AccessKeyId == null && s3SecretAccessKey ==
null) ||
(s3AccessKeyId != null && s3SecretAccessKey != null),
"S3 client access key ID and secret access key must be set at the
same time");
+ this.clientHttpType = PropertyUtil.propertyAsString(properties,
+ AwsProperties.CLIENT_HTTP_TYPE,
AwsProperties.CLIENT_HTTP_TYPE_DEFAULT);
+ }
+ }
+
+ static SdkHttpClient.Builder getHttpClientBuilder(String clientHttpType) {
Review comment:
prefer more specific verb for method instead of `get`, maybe
`configureHttpClientBuilder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
