jackye1995 commented on a change in pull request #4371:
URL: https://github.com/apache/iceberg/pull/4371#discussion_r832621318



##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -208,6 +208,27 @@
    */
   public static final String CLIENT_FACTORY = "client.factory";
 
+  /**
+   * The type of {@link software.amazon.awssdk.http.SdkHttpClient} 
implementation used by {@link AwsClientFactory}
+   * If set, all AWS clients will use this specified HTTP client.
+   * If not set, CLIENT_HTTP_TYPE_DEFAULT will be used.
+   * For specific types supported, see CLIENT_HTTP_TYPE_* defined below.
+   */
+  public static final String CLIENT_HTTP_TYPE = "client.http.type";

Review comment:
       I am a bit hesitated about this config name (although I proposed 
myself...), maybe we can have something better, @xiaoxuandev @amogh-jahagirdar 
@rajarshisarkar @singhpk234 if there is any better suggestion let us know!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to