rdblue opened a new pull request, #5236: URL: https://github.com/apache/iceberg/pull/5236
This ensures that `iceberg-build.properties` is added to Jars produced by the Gradle build, even when building from a source tarball with no `.git` directory. This builds on the `generateGitProperties` task added in #5228 and updates the build: * A new task, `buildInfo` ensures that `build/iceberg-build.properties` exists, either by copying it from the source root or by calling `generateGitProperties` (change in `tasks.gradle`) * All Jars will now include `iceberg-build.properties` from the root `build` folder (change in `deploy.gradle`) * The source release script will generate `iceberg-build.properties` and add it to the root folder for the release candidate tarball (changes in `source-release.sh`) Note that this also changes how release tarballs are created. Previously, the `source-release.sh` script would create `version.txt` and commit the file, then tag the commit with `version.txt`. This wasn't possible for adding `iceberg-build.properties` because `iceberg-build.properties` needs to describe the git commit in the source tarball (and can't be included in the commit itself). Instead of adding the file to git, this adds both `version.txt` and `iceberg-build.properties` directly to the archive using `git archive ... --add-file`. A side benefit is that we will no longer have release tags off of the master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
