rdblue commented on code in PR #5236:
URL: https://github.com/apache/iceberg/pull/5236#discussion_r917443074
##########
build.gradle:
##########
@@ -51,7 +51,7 @@ try {
gitPropertiesName = 'iceberg-build.properties'
gitPropertiesResourceDir = file("${rootDir}/build")
extProperty = 'gitProps'
- failOnNoGitDirectory = false
+ failOnNoGitDirectory = true
Review Comment:
No, this actually doesn't do much. The plugin is configured in a try/catch
after the Palantir version plugin. So if there is not .git directory, this code
doesn't even run.
Eventually, we should see if this can be moved outside of the try/catch,
which was my intent here. I think that if `generateGitProperties` is called and
it can't, then we want to have a failure. That's why this introduces a new
task, `buildInfo` that will use the properties file in the build root if it is
present. The failure we want is when you have no `.git` directory and have no
`iceberg-build.properties` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
