[GitHub] [iceberg] kbendick commented on a diff in pull request #5236: Build: Add iceberg-build.properties to Jars and release process

[GitBox]

kbendick commented on code in PR #5236:
URL: https://github.com/apache/iceberg/pull/5236#discussion_r917445685


##########
build.gradle:
##########
@@ -51,7 +51,7 @@ try {
     gitPropertiesName = 'iceberg-build.properties'
     gitPropertiesResourceDir = file("${rootDir}/build")
     extProperty = 'gitProps'
-    failOnNoGitDirectory = false
+    failOnNoGitDirectory = true

Review Comment:
   I tried without the try catch and having `gitProperties` in the build file 
causes even simple tasks like `gradle tasks` to fail because the surrounding 
`gitProperties` block is not registered and has no meaning to gradle. Even if 
it’s not used, such as `gradle clean`.
   
   So my observation was that the try-catch block will always be needed for any 
`gitProperties` block.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org