kbendick commented on code in PR #5236:
URL: https://github.com/apache/iceberg/pull/5236#discussion_r917446399
##########
build.gradle:
##########
@@ -51,7 +51,7 @@ try {
gitPropertiesName = 'iceberg-build.properties'
gitPropertiesResourceDir = file("${rootDir}/build")
extProperty = 'gitProps'
- failOnNoGitDirectory = false
+ failOnNoGitDirectory = true
Review Comment:
I think this flag is more for the case that somebody overrides the `.git`
directory - which the plug-in allows - and that overridden directory isn’t
present (at least from my testing). But git is still present so the plug-in is
able to be applied in general.
Ryan’s right that it doesn’t do much and the flag won’t cause the build to
fail when using the tarball.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
