kbendick commented on code in PR #5236:
URL: https://github.com/apache/iceberg/pull/5236#discussion_r917446840
##########
dev/source-release.sh:
##########
@@ -109,7 +110,11 @@ fi
# archive (identical hashes) using the scm tag
echo "Creating tarball ${tarball} using commit $release_hash"
tarball=$tag.tar.gz
-git archive $release_hash --worktree-attributes --prefix $tag/ -o
$projectdir/$tarball
+git archive $release_hash --worktree-attributes --prefix $tag/ --add-file
$projectdir/version.txt --add-file $projectdir/iceberg-build.properties -o
$projectdir/$tarball
+
+# remove the uncommitted build files so they don't affect the current working
copy
+rm $projectdir/version.txt
+rm $projectdir/iceberg-build.properties
Review Comment:
Will there be any commit specifically for the release or will it simply be
the last commit that goes into the release branch? Previously the version.txt
commit wound up being the source release commit.
To be clear, I am definitely in agreement on removing the `git commit` from
this script. It has caused several people issues while testing releasing in the
past or when the release script needed to be rerun for the same RC candidate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
