stevenzwu commented on code in PR #5486:
URL: https://github.com/apache/iceberg/pull/5486#discussion_r945412786
##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -169,29 +171,44 @@ public void testUpsertAndQuery() {
public void testPrimaryKeyEqualToPartitionKey() {
Review Comment:
I feel we probably don't need to change this test method. there is no need
to use the same schema as the previous method. there is an extra column for
cognitive burden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
