stevenzwu commented on code in PR #5486:
URL: https://github.com/apache/iceberg/pull/5486#discussion_r946322759
##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -171,27 +173,27 @@ public void testPrimaryKeyEqualToPartitionKey() {
String tableName = "upsert_on_data_key";
try {
sql(
- "CREATE TABLE %s(id INT NOT NULL, data STRING NOT NULL, PRIMARY
KEY(data) NOT ENFORCED) "
Review Comment:
I know I suggested `name` for the test method above. I am fine with
expanding the scope to all test methods.
Let's also hear if other people have different take and think changing
`data` to `name` is unnecessary here and below. I am fine either way. will
approve the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
