hililiwei commented on code in PR #5486:
URL: https://github.com/apache/iceberg/pull/5486#discussion_r949038790
##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -203,40 +205,40 @@ public void testPrimaryKeyFieldsAtBeginningOfSchema() {
LocalDate dt = LocalDate.of(2022, 3, 1);
try {
sql(
- "CREATE TABLE %s(data STRING NOT NULL, dt DATE NOT NULL, id INT,
PRIMARY KEY(data,dt) NOT ENFORCED) "
- + "PARTITIONED BY (data) WITH %s",
+ "CREATE TABLE %s(name STRING NOT NULL, dt DATE NOT NULL, id INT,
PRIMARY KEY(name,dt) NOT ENFORCED) "
Review Comment:
Also, I'd like to ask @kbendick that if we use the following sql, this test
will be very similar to `testUpsertAndQuery`.
`"CREATE TABLE %s(id INT NOT NULL, dt DATE NOT NULL, name STRING, PRIMARY
KEY(id,dt) NOT ENFORCED) "`
Can we merge the two into one?
Anything that cuts down the UT time, it's worth it.
##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -203,40 +205,40 @@ public void testPrimaryKeyFieldsAtBeginningOfSchema() {
LocalDate dt = LocalDate.of(2022, 3, 1);
try {
sql(
- "CREATE TABLE %s(data STRING NOT NULL, dt DATE NOT NULL, id INT,
PRIMARY KEY(data,dt) NOT ENFORCED) "
- + "PARTITIONED BY (data) WITH %s",
+ "CREATE TABLE %s(name STRING NOT NULL, dt DATE NOT NULL, id INT,
PRIMARY KEY(name,dt) NOT ENFORCED) "
Review Comment:
Also, I'd like to ask @kbendick that if we use the following sql, this test
will be very similar to `testUpsertAndQuery`.
`"CREATE TABLE %s(id INT NOT NULL, dt DATE NOT NULL, name STRING, PRIMARY
KEY(id,dt) NOT ENFORCED) "`
Can we merge the two into one?
Anything that cuts down the UT time, it's worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
