lvyanquan commented on code in PR #5486:
URL: https://github.com/apache/iceberg/pull/5486#discussion_r945586699
##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -203,40 +220,40 @@ public void testPrimaryKeyFieldsAtBeginningOfSchema() {
LocalDate dt = LocalDate.of(2022, 3, 1);
try {
sql(
- "CREATE TABLE %s(data STRING NOT NULL, dt DATE NOT NULL, id INT,
PRIMARY KEY(data,dt) NOT ENFORCED) "
- + "PARTITIONED BY (data) WITH %s",
+ "CREATE TABLE %s(id INT, name STRING NOT NULL, dt DATE NOT NULL,
PRIMARY KEY(name,dt) NOT ENFORCED) "
Review Comment:
Thanks for your suggestion, my understanding of this test has improved.
I have re-submitted the code and you may review again to check what else
needs to be changed when you are free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
